[BRE-1194] update publish-gh-release to every hour when triggered by publish-store #1945
+70
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmyLGalles
changed the title
AmyLGalles
changed the title
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1945 +/- ##
==========================================
- Coverage 85.28% 82.94% -2.34%
==========================================
Files 1690 1993 +303
Lines 144051 161054 +17003
==========================================
+ Hits 122847 133594 +10747
- Misses 21204 27460 +6256 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pixman20
reviewed
Sep 19, 2025
AmyLGalles
changed the title
pixman20
requested changes
Oct 3, 2025
| name: Publish Password Manager Release | ||
| uses: bitwarden/gh-actions/.github/workflows/_publish-mobile-github-release.yml@main | ||
| with: | ||
| workflow_name: "publish-github-release-pwm.yml" |
There was a problem hiding this comment.
⚒️ I think this workflow should be renamed to pm rather than pwm
Suggested change
| workflow_name: "publish-github-release-pwm.yml" | |
| workflow_name: "publish-github-release-pm.yml" |
There was a problem hiding this comment.
Why on this workflow and not the android ones?
AmyLGalles
force-pushed
the
agalles/BRE-1118-update-mobile-release
branch
from
54362a2 to
05d2661
Compare
aj-bw
approved these changes
Oct 10, 2025
pixman20
approved these changes
Oct 13, 2025
vvolkgang
approved these changes
Oct 14, 2025
fedemkr
approved these changes
Oct 14, 2025
Comment on lines
+149
to
+153
| if [ "$PRODUCT" = "Password Manager" ]; then | ||
| gh workflow enable publish-github-release-bwpm.yml | ||
| elif [ "$PRODUCT" = "Authenticator" ]; then | ||
| gh workflow enable publish-github-release-bwa.yml | ||
| fi |
There was a problem hiding this comment.
⛏️ Should this have a fallback with an echo saying that the product is not recognized or something like that? i.e. when it's not neither Password Manager nor Authenticator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updated was tested during the 10/2/25 clients release
Added dry-run option to publish-store.yml
publish-store.yml will enable github release workflows once release to the ios app store is complete.
publish-github-release.yml is now publish-github-release-bwa.yml and publish-github-release-bwa.yml so that they can be enabled or disabled based on which project was released. They now run hourly when enabled.
The workflow gh-actions/_publish-mobile-github-release.yml disables the workflow that ran it once it completes successfully.
🎟️ Tracking
Original Ticket
Follow up for testing
📔 Objective
Right now the check runs at 3am M-F, so if it fails on a Friday it doesn’t run again until Monday, which causes CI jobs to fail. This happens since they use the existing GH release to determine the version and cannot upload using the same version that’s currently rolling out.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes